How do you know a relationship isnt going to work?

Well me and my boyfreind have been going out for 1 year and 2 months now. He was a he graduated last year and im still in HS. Hes 18 and im 17. Well hes going to a college 2 hours away. My parents are really strict. I get to see him maybe 2 times a week. Well me and him where really happy. and we love each other so much. Hes my bestfreind everything. Hes the best thing that has ever came in my life. Hes not the problem I AM. Im always trying to start fights with him and I always try to push his buttons. AND I DONT KNOW WHY! Well hes never done ANYTHING bad or to hurt me. I’ve made out with a girl that was Bi even though im not. im not sure if that was cheating but I considered it. Even though hes all the way in a place where most guys wouldnt be faithful he has be. I dont treat him the way he should be treated and I feel so bad. I know he deserves better but I LOVE HIM SO MUCH. I dont wanna let him go and he loves me so much to. Im always the one who makes the mistake and he always forgives me. He does the smallest thing thats wrong and I get mad at him. I think its just so much anger inside of me that hes so far away and I cant be with him. I know its not our fault. Especailly his. I dont know if I should let him go. He doesnt wanna break up but I think its better for him All I want is for him to be happy and I dont wanna have him to deal with my tantrums. Or I dont know if I should be selffish and keep being with him and make myself happy and TRY to change for the 100th time I really need a second opinion…